This repository was archived by the owner on May 31, 2024. It is now read-only.
feat: Improve context stack deployment speed#150
Merged
Conversation
tneely
suggested changes
Nov 8, 2021
| /** | ||
| * AWS Batch JobQueue to use for running workflows. | ||
| */ | ||
| readonly jobQueue: IJobQueue; |
Contributor
There was a problem hiding this comment.
I don't see this being used anywhere. Is it needed?
Contributor
Author
There was a problem hiding this comment.
Yup, its used a few times. Here is one: https://github.com/aws/amazon-genomics-cli/pull/150/files#diff-8623b226bf6f1a3639f3853bdccb79a30a41db59747e010dbe8fc601353f9273R38 . This jobQueue object was previously in the engine options type, which stopped miniwdl's props from extending that type. Removing it and putting it within the props allows for the engine options type to be used across all constructs.
tneely
changed the title
tneely
previously approved these changes
Nov 10, 2021
ghawk1ns
previously approved these changes
Nov 15, 2021
tneely
approved these changes
Nov 16, 2021
nbraid
approved these changes
Nov 16, 2021
AndreyDovydenko
pushed a commit
that referenced
this pull request
Nov 24, 2021
* Unnested context stack implementation * Class name refactoring
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Combine nested stacks to single stack to speed up deployment time.
Description of how you validated changes
Deployed cromwell, nextflow contexts and ran workflows to validate changes. Tested log retrieval for workflows as well. Workflows tested:
Context deployment was running on average for 12 minutes rather then 18 during these deployments
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license