Skip to content
This repository was archived by the owner on May 31, 2024. It is now read-only.

fix: progress bar doesn't show any progress#166

Merged
tneely merged 1 commit into
mainfrom
illya/progress-fix
Nov 12, 2021
Merged

fix: progress bar doesn't show any progress#166
tneely merged 1 commit into
mainfrom
illya/progress-fix

Conversation

@IllyaYalovyy
Copy link
Copy Markdown
Contributor

Issue #, if available:

Description of Changes

The progress bar update was broken because of incorrect regex expression

Description of how you validated changes

  • make
  • unit tests
  • manual test

Checklist

  • If this change would make any existing documentation invalid, I have included those updates within this PR
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have linted my code before raising the PR
  • Title of this Pull Request follows Conventional Commits standard: https://www.conventionalcommits.org/en/v1.0.0/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@IllyaYalovyy IllyaYalovyy temporarily deployed to slack November 11, 2021 23:49 Inactive
@ghawk1ns
Copy link
Copy Markdown
Contributor

https://xkcd.com/1171/

@tneely tneely merged commit 9dd17ae into main Nov 12, 2021
@tneely tneely deleted the illya/progress-fix branch November 12, 2021 00:28
a-li pushed a commit that referenced this pull request Nov 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants