This repository was archived by the owner on May 31, 2024. It is now read-only.
fix: Return timezone information in RunLog#174
Conversation
Currently the CLI and WES adapter are using different ISO time formats. The CLI expects a timezone, and the Batch WES adapter is not returning one. This commit adds timezone information to the returned timestamps so the CLI can parse them.
IllyaYalovyy
approved these changes
Nov 13, 2021
tneely
approved these changes
Nov 13, 2021
a-li
pushed a commit
that referenced
this pull request
Nov 15, 2021
Currently the CLI and WES adapter are using different ISO time formats. The CLI expects a timezone, and the Batch WES adapter is not returning one. This commit adds timezone information to the returned timestamps so the CLI can parse them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of Changes
Currently the CLI and WES adapter are using different ISO time formats.
The CLI expects a timezone, and the Batch WES adapter is not returning one.
This commit adds timezone information to the returned timestamps so the CLI
can parse them.
Description of how you validated changes
Workflow logs command now parses the timestamps appropriately.
Old
New:
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license