Skip to content
This repository was archived by the owner on May 31, 2024. It is now read-only.

feat: don't use ebs auto scale for minidl#300

Merged
markjschreiber merged 3 commits into
mainfrom
markjschreiber/feat/no-ebs-autoscale-miniwdl
Feb 2, 2022
Merged

feat: don't use ebs auto scale for minidl#300
markjschreiber merged 3 commits into
mainfrom
markjschreiber/feat/no-ebs-autoscale-miniwdl

Conversation

@markjschreiber
Copy link
Copy Markdown
Contributor

@markjschreiber markjschreiber commented Feb 2, 2022

Issue #, if available:

#278
#275

Description of Changes

  • Make LaunchTemplate user data aware of workflow orchestrator (engine). Don't use ebs-autoscale when running miniwdl.
  • Add code comment about the need to redeploy contexts when changing the LaunchTemplate.
  • Change shutdown to echo error because shutdown won't cause batch to restart a new instance.
  • Exposed initial ebs volume size to provision.sh to make it easier to change this value.
  • fixed additional typo/ bug from issue 275

Description of how you validated changes

Because the changes here modify the ecs-additions scripts a full account deactivate, activate is required.

  • deploy miniwdl context and run demo-wdl-project workflows. Make sure the autoexpand EBS volume is not created on batch workers
  • deploy cromwell context and run demo-wdl-project workflows. Make sure the autoexpand EBS volume is still created on batch workers

Checklist

  • If this change would make any existing documentation invalid, I have included those updates within this PR
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have linted my code before raising the PR
  • Title of this Pull Request follows Conventional Commits standard: https://www.conventionalcommits.org/en/v1.0.0/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@markjschreiber markjschreiber self-assigned this Feb 2, 2022
@markjschreiber markjschreiber temporarily deployed to slack February 2, 2022 01:30 Inactive
Comment thread packages/cdk/lib/artifacts/batch-artifacts/ecs-additions/provision.sh Outdated
Comment thread packages/cdk/lib/constants.ts Outdated
Comment thread packages/cdk/lib/constructs/launch-template-data.ts
@markjschreiber markjschreiber merged commit 225d139 into main Feb 2, 2022
@markjschreiber markjschreiber deleted the markjschreiber/feat/no-ebs-autoscale-miniwdl branch February 2, 2022 18:57
@a-li a-li mentioned this pull request Feb 2, 2022
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants