Skip to content

Address clippy failures and update sdk behavior versions #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
Merged

Address clippy failures and update sdk behavior versions #869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2,457 changes: 1,218 additions & 1,239 deletions Cargo.lock
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion crates/chat-cli/src/auth/builder_id.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ pub fn client(region: Region) -> Client {
Client::new(
&aws_types::SdkConfig::builder()
.http_client(crate::aws_common::http_client::client())
.behavior_version(BehaviorVersion::v2025_01_17())
.behavior_version(BehaviorVersion::v2025_08_07())
.endpoint_url(oidc_url(&region))
.region(region)
.retry_config(RetryConfig::standard().with_max_attempts(3))
Expand Down
2 changes: 1 addition & 1 deletion crates/chat-cli/src/aws_common/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ pub fn app_name() -> AppName {
}

pub fn behavior_version() -> BehaviorVersion {
BehaviorVersion::v2025_01_17()
BehaviorVersion::v2025_08_07()
}

#[cfg(test)]
Expand Down
2 changes: 1 addition & 1 deletion crates/chat-cli/src/telemetry/cognito.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ pub async fn get_cognito_credentials_send(
trace!("Creating new cognito credentials");

let conf = aws_sdk_cognitoidentity::Config::builder()
.behavior_version(BehaviorVersion::v2025_01_17())
.behavior_version(BehaviorVersion::v2025_08_07())
.region(telemetry_stage.region.clone())
.app_name(app_name())
.build();
Expand Down
2 changes: 1 addition & 1 deletion crates/chat-cli/src/telemetry/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ impl TelemetryClient {
Some(ToolkitTelemetryClient::from_conf(
Config::builder()
.http_client(crate::aws_common::http_client::client())
.behavior_version(BehaviorVersion::v2025_01_17())
.behavior_version(BehaviorVersion::v2025_08_07())
.endpoint_resolver(StaticEndpoint(TelemetryStage::EXTERNAL_PROD.endpoint))
.app_name(app_name())
.region(TelemetryStage::EXTERNAL_PROD.region.clone())
Expand Down
2 changes: 1 addition & 1 deletion crates/fig_auth/src/builder_id.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ pub(crate) fn client(region: Region) -> Client {
let retry_config = RetryConfig::standard().with_max_attempts(3);
let sdk_config = aws_types::SdkConfig::builder()
.http_client(fig_aws_common::http_client::client())
.behavior_version(BehaviorVersion::v2025_01_17())
.behavior_version(BehaviorVersion::v2025_08_07())
.endpoint_url(oidc_url(&region))
.region(region)
.retry_config(retry_config)
Expand Down
2 changes: 1 addition & 1 deletion crates/fig_aws_common/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ pub fn app_name() -> AppName {
}

pub fn behavior_version() -> BehaviorVersion {
BehaviorVersion::v2025_01_17()
BehaviorVersion::v2025_08_07()
}

#[cfg(test)]
Expand Down
2 changes: 1 addition & 1 deletion crates/fig_telemetry/src/cognito.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ pub(crate) async fn get_cognito_credentials_send(
telemetry_stage: &TelemetryStage,
) -> Result<Credentials, CredentialsError> {
let conf = aws_sdk_cognitoidentity::Config::builder()
.behavior_version(BehaviorVersion::v2025_01_17())
.behavior_version(BehaviorVersion::v2025_08_07())
.region(telemetry_stage.region.clone())
.app_name(app_name())
.build();
Expand Down
2 changes: 1 addition & 1 deletion crates/fig_telemetry/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ impl Client {
let toolkit_telemetry_client = Some(amzn_toolkit_telemetry_client::Client::from_conf(
Config::builder()
.http_client(fig_aws_common::http_client::client())
.behavior_version(BehaviorVersion::v2025_01_17())
.behavior_version(BehaviorVersion::v2025_08_07())
.endpoint_resolver(StaticEndpoint(telemetry_stage.endpoint))
.app_name(app_name())
.region(telemetry_stage.region.clone())
Expand Down
4 changes: 2 additions & 2 deletions crates/zbus/src/connection/socket/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ pub trait ReadHalf: std::fmt::Debug + Send + Sync + 'static {
/// The default implementation simply panics. Implementers must override either `read_message`
/// or this method.
async fn recvmsg(&mut self, _buf: &mut [u8]) -> RecvmsgResult {
unimplemented!("`ReadHalf` implementers must either override `read_message` or `recvmsg`");
panic!("`ReadHalf` implementers must either override `read_message` or `recvmsg`");
}

/// Return whether passing file descriptors is supported.
Expand Down Expand Up @@ -299,7 +299,7 @@ pub trait WriteHalf: std::fmt::Debug + Send + Sync + 'static {
/// The default implementation simply panics. Implementers must override either `send_message`
/// or this method.
async fn sendmsg(&mut self, _buffer: &[u8], #[cfg(unix)] _fds: &[BorrowedFd<'_>]) -> io::Result<usize> {
unimplemented!("`WriteHalf` implementers must either override `send_message` or `sendmsg`");
panic!("`WriteHalf` implementers must either override `send_message` or `sendmsg`");
}

/// The dbus daemon on `freebsd` and `dragonfly` currently requires sending the zero byte
Expand Down
Loading