Skip to content

Remove legacy chat-cli crate #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2025
Merged

Remove legacy chat-cli crate #884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5953559
Remove legacy chat-cli crate
kkashilk Oct 31, 2025
e262e8d
update readme file
kkashilk Oct 31, 2025
48b358e
fix windows tests and clippy
kkashilk Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ jobs:
- name: Run tests
run: cargo test --locked --workspace --lib --bins --test '*' --exclude fig_desktop-fuzz

cargo-clippy-windows-chat-cli:
Copy link

@abhraina-aws abhraina-aws Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title doesnt talk about this. What is this related to?

Copy link
Contributor Author

@kkashilk kkashilk Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just updated the github workflow files to remove references to chat-cli crate/string in general.
No real impact from this change

name: Clippy Windows (chat_cli)
cargo-clippy-windows:
name: Clippy Windows
runs-on: windows-latest
timeout-minutes: 60
steps:
Expand All @@ -107,11 +107,11 @@ jobs:
~/.cargo/registry/cache/
~/.cargo/git/db/
target/
key: cargo-clippy-windows-chat-cli-${{ hashFiles('**/Cargo.lock') }}-${{ steps.toolchain.outputs.cachekey }}
- run: cargo clippy --locked -p chat_cli --color always -- -D warnings
key: cargo-clippy-windows-${{ hashFiles('**/Cargo.lock') }}-${{ steps.toolchain.outputs.cachekey }}
- run: cargo clippy --locked -p q_cli --color always -- -D warnings

cargo-test-windows-chat-cli:
name: Test Windows (chat_cli)
cargo-test-windows:
name: Test Windows
runs-on: windows-latest
timeout-minutes: 60
steps:
Expand All @@ -127,9 +127,9 @@ jobs:
~/.cargo/registry/cache/
~/.cargo/git/db/
target/
key: cargo-test-windows-chat-cli-${{ hashFiles('**/Cargo.lock') }}-${{ steps.toolchain.outputs.cachekey }}
key: cargo-test-windows-${{ hashFiles('**/Cargo.lock') }}-${{ steps.toolchain.outputs.cachekey }}
- name: Run tests
run: cargo test --locked -p chat_cli
run: cargo test --locked -p q_cli

cargo-fmt:
name: Fmt
Expand Down
Loading
Loading