Skip to content

fix: remove the update lock after a successful update with macOS #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2025
Merged

fix: remove the update lock after a successful update with macOS #960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions crates/q_cli/src/cli/internal/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ use fig_proto::util::get_shell;
use fig_util::directories::{
figterm_socket_path,
logs_dir,
update_lock_path,
};
use fig_util::env_var::QTERM_SESSION_ID;
use fig_util::{
Expand Down Expand Up @@ -253,6 +254,8 @@ pub enum InternalSubcommand {
DumpState {
component: StateComponent,
},
/// Currently only used by macOS after finishing an update. The old binary calls `FinishUpdate`
/// on the new binary at the end of updating.
FinishUpdate {
#[arg(long)]
relaunch_dashboard: bool,
Expand Down Expand Up @@ -785,6 +788,8 @@ impl InternalSubcommand {
})
.ok();

let _ = tokio::fs::remove_file(update_lock_path(&fig_os_shim::Context::new())?).await;

Ok(ExitCode::SUCCESS)
},
#[cfg(target_os = "macos")]
Expand Down
Loading