fix panic due to nil eventRecorder in GatewayReconciler #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can you add issue and include the crash stacktrace to the issue first? thanks |
Contributor
Author
|
I can recreate the panic ... but I think if you look at the code you can easily spot that the eventRecorder is being initialized as nil and will panic when an event is recorded. Let me know if you still want me to reproduce the panic. |
Contributor
|
If you can recreate the crash, please add crash stacktrace. thanks |
liwenwu-amazon
approved these changes
Mar 9, 2023
Contributor
liwenwu-amazon
left a comment
liwenwu-amazon
left a comment
There was a problem hiding this comment.
lgtm. thanks, Also, please add crash stack trace when you have it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Description of changes:
set the eventRecorder when creating a new GatewayReconciler to avoid panic when trying to create an event
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.