Skip to content

Conversation

@xWink
Copy link
Member

@xWink xWink commented Jun 16, 2023

What type of PR is this?
Added missing tests

Which issue does this PR fix:
#257

What does this PR do / Why do we need it:
Adds e2e tests for Kubernetes Service and Deployment deletion to verify that VPC Lattice Targets corresponding to the Service and Deployment are deregistered from their Target Group.

If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
N/A

Testing done on this change:
Ran all e2e tests to verify the new ones work and previous ones are unaffected.

• [260.678 seconds]
------------------------------

Ran 5 of 5 Specs in 1742.740 seconds
SUCCESS! -- 5 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestIntegration (1743.65s)
PASS

Automation added to e2e:
N/A

Will this PR introduce any new dependencies?:
No.

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No. Yes.

Does this PR introduce any user-facing change?:
No.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5285142338

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 32.456%

Totals Coverage Status
Change from base Build 5282756813: 0.0%
Covered Lines: 3279
Relevant Lines: 10103

💛 - Coveralls

Copy link
Contributor

@zijun726911 zijun726911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tho I think this issue #257 intend to test some deletion order changes, e.g.,:

test 1: delete deployment first, (then sleep for a while?), then delete service, verify targets are de-registered
test 2: delete service first, (then sleep for a while?), then delete deployment, verify targets are de-registered

@xWink
Copy link
Member Author

xWink commented Jun 19, 2023

LGTM, tho I think this issue #257 intend to test some deletion order changes, e.g.,:

test 1: delete deployment first, (then sleep for a while?), then delete service, verify targets are de-registered test 2: delete service first, (then sleep for a while?), then delete deployment, verify targets are de-registered

Thank you!

And, deletion of either a service or deployment causes the controller to de-register targets. Since they don't both need to be deleted, we don't need to test that deletion in a specific order causes target de-registration, just that either deletion use-case works.

Copy link
Contributor

@zmingxi zmingxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xWink xWink merged commit 518899f into aws:main Jun 19, 2023
@xWink xWink deleted the 257 branch June 19, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants