Correct Failing E2E Tests #703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikestvz
reviewed
Feb 5, 2025
erikfuller
previously requested changes
Feb 5, 2025
Contributor
erikfuller
left a comment
erikfuller
left a comment
There was a problem hiding this comment.
Thanks for digging into this. Really just my one question around the retryer code to address before moving ahead.
iph
approved these changes
Feb 6, 2025
iph
left a comment
iph
left a comment
There was a problem hiding this comment.
LGTM, had a clarifying question around amount of retries but that's about it.
| MinRetryDelay: 1 * time.Second, | ||
| MaxThrottleDelay: 5 * time.Second, | ||
| MaxRetryDelay: 5 * time.Second, | ||
| NumMaxRetries: 3, |
There was a problem hiding this comment.
What's the default retries we are overriding?
I get that these are integration tests -- but 3 is "quite a bit".
Contributor
Author
There was a problem hiding this comment.
The default retries is actually already three, probably best I remove it here to avoid any confusion. For some more context:
const (
// DefaultRetryerMaxNumRetries sets maximum number of retries
DefaultRetryerMaxNumRetries = 3
// DefaultRetryerMinRetryDelay sets minimum retry delay
DefaultRetryerMinRetryDelay = 30 * time.Millisecond
// DefaultRetryerMinThrottleDelay sets minimum delay when throttled
DefaultRetryerMinThrottleDelay = 500 * time.Millisecond
// DefaultRetryerMaxRetryDelay sets maximum retry delay
DefaultRetryerMaxRetryDelay = 300 * time.Second
// DefaultRetryerMaxThrottleDelay sets maximum delay when throttled
DefaultRetryerMaxThrottleDelay = 300 * time.Second
)
iph
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug
Which issue does this PR fix:
#673
What does this PR do / Why do we need it:
Increases timeout on E2E tests and adds a custom retryer to address these failures.
Testing done on this change:
Automation added to e2e:
N/A
Will this PR introduce any new dependencies?:
No.
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No.
Does this PR introduce any user-facing change?:
No.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.