Skip to content

Conversation

@rlymbur
Copy link
Contributor

@rlymbur rlymbur commented Feb 7, 2025

What type of PR is this?
Enhancement

Which issue does this PR fix:
#705

What does this PR do / Why do we need it:

  • Adding Merge Queue support will run E2E tests after PR approval, but before merge, to catch regressions before they are in main. This mechanism also ensures arbitrary test code is not executed on every PR before it is approved.
  • Updates our PR template to include a section confirming make e2e-test is successful to help catch issues earlier.
  • Alters the DefaultRetryer used in RAM tests to combat additional ThrottlingExceptions until controller optimizations can be made

Testing done on this change:

N/A

Automation added to e2e:

N/A

Will this PR introduce any new dependencies?:

No.

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No.

Does this PR introduce any user-facing change?:

No.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rlymbur rlymbur enabled auto-merge February 7, 2025 17:16
Copy link
Contributor

@mikestvz mikestvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rlymbur rlymbur added this pull request to the merge queue Feb 7, 2025
Merged via the queue into aws:main with commit 964f9cd Feb 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants