Add support for additional tags on vpc lattice resources #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlymbur
reviewed
Oct 6, 2025
| } | ||
|
|
||
| if len(tagsToAdd) > 0 { | ||
| _, err := t.TagResourcesWithContext(ctx, &taggingapi.TagResourcesInput{ |
There was a problem hiding this comment.
Do the recent exponential throttling improvements apply here as well?
There was a problem hiding this comment.
Incase of an error, it would retry with an exponential backoff.
| } | ||
|
|
||
| currentTags := k8s.GetNonAWSManagedTags(existingTags[resourceArn]) | ||
| filteredNewTags := k8s.GetNonAWSManagedTags(newTags) |
There was a problem hiding this comment.
It would be useful to do some pre-validation if we can based on general AWS tagging guidelines
There was a problem hiding this comment.
Added validation for:
- Key length (128 characters)
- Key can't start with prefix
aws: - Value length (256 characters)
- Maximum number of tags (50)
- Tag pattern:
^([\p{L}\p{Z}\p{N}_.:\/=+\-@]*)$
Taken from: https://docs.aws.amazon.com/resourcegroupstagging/latest/APIReference/API_Tag.html
Changes: 34889a4
rlymbur
approved these changes
Oct 6, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 7, 2025
* Add support for additional tags on vpc lattice resources * add documentation for additional tags * add validation for tags --------- Co-authored-by: vbedi <vbedi@amazon.com>
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do / Why do we need it:
This PR adds support for adding additional tags on VPC Lattice resources created via the controller.
If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
#611
Testing done on this change:
Added e2e-tests and unit tests.
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No breaking changes
Does this PR introduce any user-facing change?:
Yes, this PR adds support for additional tags.
Do all end-to-end tests successfully pass when running
make e2e-test?:Yes, all existing and new tests pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.