fix(toolkit-lib): synth time is not measured accurately#1121
Merged
aws-cdk-automation merged 3 commits intomainfrom Feb 9, 2026
Merged
fix(toolkit-lib): synth time is not measured accurately#1121aws-cdk-automation merged 3 commits intomainfrom
aws-cdk-automation merged 3 commits intomainfrom
Conversation
In multiple places the `SYNTH` span doesn't measure the time to
synthesize the assembly, but rather the time to select stacks from an
already-synthesized assembly.
Presumably this was done in order to avoid duplicating this line:
```ts
const selectStacks = options.stacks ?? ALL_STACKS;
```
Instead, introduce a helper function that gets called from all places,
and centralize the `selectStacks` logic so we don't fear duplication
anymore.
rix0rrr
requested a deployment
to
integ-approval
GitHub Actions
Waiting
kaizencc
approved these changes
Feb 5, 2026
rix0rrr
had a problem deploying
to
integ-approval
GitHub Actions
Failure
rix0rrr
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1121 +/- ##
=======================================
Coverage 87.71% 87.71%
=======================================
Files 72 72
Lines 10116 10116
Branches 1336 1336
=======================================
Hits 8873 8873
Misses 1217 1217
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In multiple places the
SYNTHspan doesn't measure the time to synthesize the assembly, but rather the time to select stacks from an already-synthesized assembly.Presumably this was done in order to avoid duplicating this line:
Instead, introduce a helper function that gets called from all places, and centralize the
selectStackslogic so we don't fear duplication anymore.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license