fix(integ-runner): disable update workflow by default #951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've lost 2 hours debugging why my deployment was failing trying to deploy to nonexistent and non-requested accounts and regions, and the answer was: the checked-in snapshot was nonsensical, and the update workflow will first deploy the checked-in snapshot and only then deploy the current snapshot. Good idea, bad execution: if existing snapshots are not region-agnostic they are guaranteed to fail. We should probably resynthesize them from the previous git commit instead. Whatever it is, what we do right now doesn't work so I'm disabling it.
rix0rrr
requested a deployment
to
integ-approval
GitHub Actions
Waiting
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #951 +/- ##
==========================================
- Coverage 84.50% 83.93% -0.58%
==========================================
Files 71 71
Lines 10445 10445
Branches 1344 1341 -3
==========================================
- Hits 8827 8767 -60
- Misses 1577 1639 +62
+ Partials 41 39 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…/aws-cdk-cli into huijbers/integ-runner-disable-update
rix0rrr
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
mrgrain
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've lost 2 hours
debugging why my deployment was failing trying to deploy to nonexistent and non-requested accounts and regions, and the
answer was: the checked-in snapshot was nonsensical, and the update workflow will first deploy the checked-in snapshot and only then deploy the current snapshot.
Good idea, bad execution: if existing
snapshots are not region-agnostic they are guaranteed to fail. We should probably resynthesize them from the previous git commit instead.
Whatever it is, what we do right now doesn't work so I'm disabling the default.
Turn
--disable-update-workflowinto--[no-]update-workflow, with the default beingfalse.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license