Local build does not fail

[hernit]

Using local codebuild, my buildspec does not seem to be fail to the codebuild phase transistion:
https://docs.aws.amazon.com/codebuild/latest/userguide/view-build-details.html#view-build-details-phases

I enter some random commands in order to force a failure in a stage under local:

agent_1 | [Container] 2018/07/29 23:51:23 Phase context status code: Message:
agent_1 | [Container] 2018/07/29 23:51:23 Entering phase INSTALL
agent_1 | [Container] 2018/07/29 23:51:23 Running command juawefhkejfhekj
agent_1 | /codebuild/output/tmp/script.sh: 4: /codebuild/output/tmp/script.sh: juawefhkejfhekj: not found
agent_1 |
agent_1 | [Container] 2018/07/29 23:51:23 Command did not exit successfully juawefhkejfhekj exit status 127
agent_1 | [Container] 2018/07/29 23:51:23 Phase complete: INSTALL Success: false
agent_1 | [Container] 2018/07/29 23:51:23 Phase context status code: COMMAND_EXECUTION_ERROR Message: Error while executing command: juawefhkejfhekj. Reason: exit status 127
agent_1 | [Container] 2018/07/29 23:51:23 Entering phase PRE_BUILD
agent_1 | [Container] 2018/07/29 23:51:23 Phase complete: PRE_BUILD Success: true

Using non-local codebuild with exactly the same code:

[Container] 2018/07/29 23:57:38 Phase context status code: Message:
[Container] 2018/07/29 23:57:38 Entering phase INSTALL
[Container] 2018/07/29 23:57:38 Running command juawefhkejfhekj
/codebuild/output/tmp/script.sh: 4: /codebuild/output/tmp/script.sh: juawefhkejfhekj: not found
[Container] 2018/07/29 23:57:38 Command did not exit successfully juawefhkejfhekj exit status 127
[Container] 2018/07/29 23:57:38 Phase complete: INSTALL Success: false
[Container] 2018/07/29 23:57:38 Phase context status code: COMMAND_EXECUTION_ERROR Message: Error while executing command: juawefhkejfhekj. Reason: exit status 127

Local would continue and proceed and exit with code 0, non-local will exit at failure with error.

[johnhanks1]

Thank you for the information we are looking into getting this fixed.

[afdabro]

I'm seeing a similar issue running locally with latest build agent and latest code build go image. Even though the unit tests fail and go test command returns an exit code 1 the build agent still moves to the next stage.

Local Logs

agent_1  | [Container] 2018/08/17 23:19:36 Running command go test ./internal/...
agent_1  | --- FAIL: TestTryGetMediaFormatTypeWithWildCardAccept (0.00s)
agent_1  |      apiMediaFormatter_test.go:56: should have no errors but found invalid format: */*
agent_1  | --- FAIL: TestTryGetMediaFormatTypeWithApplicationWildCardAccept (0.00s)
agent_1  |      apiMediaFormatter_test.go:70: should have no errors but found invalid format: application/*
agent_1  | FAIL
agent_1  | FAIL internal/http 0.019s
agent_1  |
agent_1  | [Container] 2018/08/17 23:19:38 Command did not exit successfully go test ./internal/... exit status 1
agent_1  | [Container] 2018/08/17 23:19:38 Phase complete: PRE_BUILD Success: false
agent_1  | [Container] 2018/08/17 23:19:38 Phase context status code: COMMAND_EXECUTION_ERROR Message: Error while executing command: go test ./internal/.... Reason: exit status 1
agent_1  | [Container] 2018/08/17 23:19:38 Entering phase BUILD
agent_1  | [Container] 2018/08/17 23:19:38 Running command GOOS=linux GOARCH=amd64 go build -o main cmd/*.go

Steps

1. clone latest aws codebuild images

git clone https://github.com/aws/aws-codebuild-docker-images.git

2. change directories to golang

cd ubuntu/golang/1.10

3. build image

docker build -t aws/codebuild/golang:1.10 .

4. Pull latest Build Agent

docker pull amazon/aws-codebuild-local:latest --disable-content-trust=false

5. Execute local build with invalid unit tests

[subinataws]

We'll push a signed image soon. In the meantime, you can try with "docker pull amazon/aws-codebuild-local:latest" to get the latest stable version.

[afdabro]

Thanks @subinataws! Updating to the latest fixes it. Unit tests are now failing the local build.

agent_1  | [Container] 2018/08/22 23:28:14 Command did not exit successfully go test ./internal/... exit status 1
agent_1  | [Container] 2018/08/22 23:28:14 Phase complete: PRE_BUILD Success: false
agent_1  | [Container] 2018/08/22 23:28:14 Phase context status code: COMMAND_EXECUTION_ERROR Message: Error while executing command: go test ./internal/.... Reason: exit status 1
agentresources_agent_1 exited with code 0
Stopping agentresources_build_1 ... done
Aborting on container exit...