Skip to content

--commit-range doesn't restrict the recommendations to changed files in that range #35

@jaron-l

Description

@jaron-l

Issue

When I run the cli command to get a security scan for a given commit range, it includes recommendations across the entire package rather than just the specified commit range.

Steps to reproduce

  1. Run aws-codeguru-cli --root-dir . --profile <profile> --mode security --commit-range HEAD^:HEAD
  2. Observe the the file at code-guru/recommendations.json includes recommendations across your entire package.

Expected Result

Only include recommendations that are part of the diff within the commit range.

Notes

I tried removing the commit range and noticed that the output is identical which makes me think that the flag is ignored.

This seems related to #9 but I wasn't able to validate the output of the jobs mentioned in that query.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions