Skip to content

ci: run unit and integration tests against more node versions #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anthonyting merged 4 commits into from
Nov 13, 2025
Merged

ci: run unit and integration tests against more node versions #221

anthonyting merged 4 commits into from
Nov 13, 2025

Conversation

@anthonyting
Copy link
Contributor

@anthonyting anthonyting commented Nov 5, 2025 •
edited
Loading

Issue #, if available:

#220

Description of changes:

Refactoring our GH workflows to run against nodejs 20.x, 22.x, 24.x.

The new workflow is like this:

  1. Build workflow is run once, uploading the build artifacts
  2. Unit tests for each node version are concurrently triggered by the build workflow (downloading from artifacts)
  3. Integration tests for each node version are concurrently triggered by the build workflow (downloading from artifacts)
  4. Cleanup workflow is run for each node version (not concurrently, since there is throttling for DeleteFunction)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@anthonyting anthonyting force-pushed the node-version-tests branch 2 times, most recently from e66af0c to 57a2065 Compare November 5, 2025 19:00
@anthonyting anthonyting marked this pull request as draft November 6, 2025 23:36
@ketpatel1998 ketpatel1998 changed the title ci: run unit and integration tests aginst more node versions feat(lambda): update internal client model Nov 8, 2025
@ketpatel1998 ketpatel1998 changed the title feat(lambda): update internal client model ci: run unit and integration tests aginst more node versions Nov 8, 2025
@anthonyting anthonyting force-pushed the node-version-tests branch 2 times, most recently from 586f924 to 7bd3cb1 Compare November 10, 2025 21:27
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 10, 2025
View reviewed changes
@anthonyting anthonyting force-pushed the node-version-tests branch 18 times, most recently from 903b982 to 565e701 Compare November 12, 2025 23:35
@anthonyting anthonyting marked this pull request as ready for review November 12, 2025 23:58
@anthonyting anthonyting changed the title ci: run unit and integration tests aginst more node versions ci: run unit and integration tests against more node versions Nov 12, 2025
@anthonyting anthonyting force-pushed the node-version-tests branch 4 times, most recently from 150607a to 4c3f740 Compare November 13, 2025 00:34
@bchampp
Copy link
Member

bchampp commented Nov 13, 2025

Should we increase our throttling limits on DeleteFunction?

@anthonyting
Copy link
Contributor Author

anthonyting commented Nov 13, 2025

Should we increase our throttling limits on DeleteFunction?

Maybe when we switch these tests to prod, but for now I think it's fine since it's still pretty fast

@anthonyting anthonyting merged commit fafcc76 into development Nov 13, 2025
16 checks passed
@anthonyting anthonyting deleted the node-version-tests branch November 13, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bchampp bchampp bchampp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anthonyting @bchampp