feat(sdk): add configureLogger method with modeAware option #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParidelPooya
force-pushed
the
feat/sdk-configure-logger-api
branch
23 times, most recently
from
02b005a to
f7aa59b
Compare
Replace setCustomLogger() with configureLogger() that accepts LoggerConfig object with customLogger and modeAware options. The modeAware flag controls whether logs are suppressed during replay mode (default: true). BREAKING CHANGE: Removed setCustomLogger() method in favor of configureLogger(). This is acceptable as the SDK has not been launched yet and there are no existing users. Changes: - Add configureLogger(config: LoggerConfig) method to DurableContext - Add LoggerConfig interface with customLogger and modeAware properties - Update createModeAwareLogger to accept modeAwareEnabled parameter - Change default modeAware behavior to true (suppress logs during replay) - Fix replay mode switching for backend-completed operations (wait, invoke, createCallback, waitForCallback) by calling checkAndUpdateReplayMode() after completion - Update all tests to reflect new default behavior and mode switching fix - Add logger-test examples with file-based logging (local-only tests) - Update documentation: README, API_SPECIFICATION.md with new API - Add TSDoc comments for Logger types and configureLogger method - Remove old logger-example with outdated information
ParidelPooya
force-pushed
the
feat/sdk-configure-logger-api
branch
from
f7aa59b to
dabee4e
Compare
- Replace async/await pattern with finally blocks in invoke, wait, createCallback, waitForCallback - Add optional chaining for promise.finally() to handle undefined promises - Add README tip about modeAware: false for local development/debugging
anthonyting
reviewed
Nov 13, 2025
...cution-sdk-js-examples/src/examples/logger-test/after-callback/logger-after-callback.test.ts
Show resolved
Hide resolved
anthonyting
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace setCustomLogger() with configureLogger() that accepts LoggerConfig
object with customLogger and modeAware options. The modeAware flag controls
whether logs are suppressed during replay mode (default: true).
Limitation:
Integration tests are against local runner and we have a issue to add it to Cloud mode: #255
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.