Skip to content

Conversation

@anthonyting
Copy link
Contributor

@anthonyting anthonyting commented Nov 30, 2025

Issue #, if available:

#261

Description of changes:

Generating history files and adding assertHistoryEvents to all non-callback and non-invoke example tests. All generated histories were created using the testing library using the generate-history.ts script (also added in this PR).

Event signatures are matching with the backend, while all histories were generated by the testing library. This means the testing library and backend have full history parity! (in terms of the examples that we have, and the event types generated - possibly not the event details yet)

Currently, all tests are logging a warning if the history isn't generated yet.

Limitations

The local runner history results do not match exactly in cases when skipTime is enabled. In particular, the number of invocations will often not be the same when running with skipTime, since the checkpoint response will instantly return the timer result, and the invocation doesn't need to exit. For tests with skipTime enabled, I have disabled InvocationCompleted assertions when running in local mode.

Additionally, some situations result in more retries when skipTime is enabled, since retries completely instantly. I have disabled skipTime in those cases (just the promise-any test).

Next steps

  • Generate histories for callback/invoke examples
  • Make tests throw an error if the event history assertion isn't there

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@anthonyting anthonyting force-pushed the enable-history-tests branch 6 times, most recently from b28bdc9 to 5e3c47b Compare December 3, 2025 01:31
@anthonyting anthonyting force-pushed the enable-history-tests branch 2 times, most recently from a384d64 to b5dbc0c Compare December 3, 2025 23:44
@anthonyting anthonyting marked this pull request as ready for review December 4, 2025 01:33
@anthonyting anthonyting merged commit c4af3ff into main Dec 4, 2025
29 of 31 checks passed
@anthonyting anthonyting deleted the enable-history-tests branch December 4, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants