Fix/avoid redundant checkpoints #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…START checkpoints - Skip START checkpoint when operation status is already STARTED to prevent redundant checkpointing on retries - Add READY status support for state restoration in wait-for-condition handler to maintain state continuity across timer completions - Replace hardcoded Action strings with OperationAction constants (START, SUCCEED, RETRY) for type safety - Add test for PENDING status scenarios in both step-handler and wait-for-condition-handler
yaythomas
approved these changes
Sep 4, 2025
packages/lambda-durable-functions-sdk-js/src/handlers/step-handler/step-handler.ts
Show resolved
Hide resolved
ParidelPooya
added a commit
that referenced
this pull request
Oct 10, 2025
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. ### Issue Link, if available SIM ticket: DAR-SDK-242 ### Description - Skip START checkpoint when operation status is already STARTED to prevent redundant checkpointing on retries - Add READY status support for state restoration in wait-for-condition handler to maintain state continuity across timer completions - Replace hardcoded Action strings with OperationAction constants (START, SUCCEED, RETRY) for type safety - Add test for PENDING status scenarios in both step-handler and wait-for-condition-handler ### Checklist - [Y] I have filled out every section of the PR template - [Y] I have thoroughly tested this change ### Testing #### Unit Tests Yes Co-authored-by: Pooya Paridel <parpooya@amazon.com>
ParidelPooya
added a commit
that referenced
this pull request
Oct 12, 2025
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. ### Issue Link, if available SIM ticket: DAR-SDK-242 ### Description - Skip START checkpoint when operation status is already STARTED to prevent redundant checkpointing on retries - Add READY status support for state restoration in wait-for-condition handler to maintain state continuity across timer completions - Replace hardcoded Action strings with OperationAction constants (START, SUCCEED, RETRY) for type safety - Add test for PENDING status scenarios in both step-handler and wait-for-condition-handler ### Checklist - [Y] I have filled out every section of the PR template - [Y] I have thoroughly tested this change ### Testing #### Unit Tests Yes Co-authored-by: Pooya Paridel <parpooya@amazon.com>
ParidelPooya
added a commit
that referenced
this pull request
Oct 24, 2025
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. ### Issue Link, if available SIM ticket: DAR-SDK-242 ### Description - Skip START checkpoint when operation status is already STARTED to prevent redundant checkpointing on retries - Add READY status support for state restoration in wait-for-condition handler to maintain state continuity across timer completions - Replace hardcoded Action strings with OperationAction constants (START, SUCCEED, RETRY) for type safety - Add test for PENDING status scenarios in both step-handler and wait-for-condition-handler ### Checklist - [Y] I have filled out every section of the PR template - [Y] I have thoroughly tested this change ### Testing #### Unit Tests Yes Co-authored-by: Pooya Paridel <parpooya@amazon.com>
ParidelPooya
added a commit
that referenced
this pull request
Oct 26, 2025
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. ### Issue Link, if available SIM ticket: DAR-SDK-242 ### Description - Skip START checkpoint when operation status is already STARTED to prevent redundant checkpointing on retries - Add READY status support for state restoration in wait-for-condition handler to maintain state continuity across timer completions - Replace hardcoded Action strings with OperationAction constants (START, SUCCEED, RETRY) for type safety - Add test for PENDING status scenarios in both step-handler and wait-for-condition-handler ### Checklist - [Y] I have filled out every section of the PR template - [Y] I have thoroughly tested this change ### Testing #### Unit Tests Yes Co-authored-by: Pooya Paridel <parpooya@amazon.com>
ParidelPooya
added a commit
that referenced
this pull request
Nov 2, 2025
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. ### Issue Link, if available SIM ticket: DAR-SDK-242 ### Description - Skip START checkpoint when operation status is already STARTED to prevent redundant checkpointing on retries - Add READY status support for state restoration in wait-for-condition handler to maintain state continuity across timer completions - Replace hardcoded Action strings with OperationAction constants (START, SUCCEED, RETRY) for type safety - Add test for PENDING status scenarios in both step-handler and wait-for-condition-handler ### Checklist - [Y] I have filled out every section of the PR template - [Y] I have thoroughly tested this change ### Testing #### Unit Tests Yes Co-authored-by: Pooya Paridel <parpooya@amazon.com>
ParidelPooya
added a commit
that referenced
this pull request
Nov 6, 2025
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. ### Issue Link, if available SIM ticket: DAR-SDK-242 ### Description - Skip START checkpoint when operation status is already STARTED to prevent redundant checkpointing on retries - Add READY status support for state restoration in wait-for-condition handler to maintain state continuity across timer completions - Replace hardcoded Action strings with OperationAction constants (START, SUCCEED, RETRY) for type safety - Add test for PENDING status scenarios in both step-handler and wait-for-condition-handler ### Checklist - [Y] I have filled out every section of the PR template - [Y] I have thoroughly tested this change ### Testing #### Unit Tests Yes Co-authored-by: Pooya Paridel <parpooya@amazon.com>
ParidelPooya
added a commit
that referenced
this pull request
Nov 6, 2025
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. ### Issue Link, if available SIM ticket: DAR-SDK-242 ### Description - Skip START checkpoint when operation status is already STARTED to prevent redundant checkpointing on retries - Add READY status support for state restoration in wait-for-condition handler to maintain state continuity across timer completions - Replace hardcoded Action strings with OperationAction constants (START, SUCCEED, RETRY) for type safety - Add test for PENDING status scenarios in both step-handler and wait-for-condition-handler ### Checklist - [Y] I have filled out every section of the PR template - [Y] I have thoroughly tested this change ### Testing #### Unit Tests Yes Co-authored-by: Pooya Paridel <parpooya@amazon.com>
ParidelPooya
added a commit
that referenced
this pull request
Nov 6, 2025
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. ### Issue Link, if available SIM ticket: DAR-SDK-242 ### Description - Skip START checkpoint when operation status is already STARTED to prevent redundant checkpointing on retries - Add READY status support for state restoration in wait-for-condition handler to maintain state continuity across timer completions - Replace hardcoded Action strings with OperationAction constants (START, SUCCEED, RETRY) for type safety - Add test for PENDING status scenarios in both step-handler and wait-for-condition-handler ### Checklist - [Y] I have filled out every section of the PR template - [Y] I have thoroughly tested this change ### Testing #### Unit Tests Yes Co-authored-by: Pooya Paridel <parpooya@amazon.com>
ParidelPooya
added a commit
that referenced
this pull request
Nov 7, 2025
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. ### Issue Link, if available SIM ticket: DAR-SDK-242 ### Description - Skip START checkpoint when operation status is already STARTED to prevent redundant checkpointing on retries - Add READY status support for state restoration in wait-for-condition handler to maintain state continuity across timer completions - Replace hardcoded Action strings with OperationAction constants (START, SUCCEED, RETRY) for type safety - Add test for PENDING status scenarios in both step-handler and wait-for-condition-handler ### Checklist - [Y] I have filled out every section of the PR template - [Y] I have thoroughly tested this change ### Testing #### Unit Tests Yes Co-authored-by: Pooya Paridel <parpooya@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
SIM ticket: DAR-SDK-242
Description
Checklist
Testing
Unit Tests
Yes