Skip to content

Conversation

@rarepolz
Copy link
Collaborator

Issue #, if available:
closes #115
Description of changes:

  • Add Operation.from_existing() classmethod
  • Add StepDetails.from_existing() and CallbackDetails.from_existing() factory methods
  • Replace all dataclasses.replace() calls with explicit constructors
  • Add test coverage for new factory methods

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rarepolz rarepolz changed the title refactor: replace dataclasses.replace with explicit factory methods refactor(sdk): replace dataclasses.replace with explicit factory methods Nov 15, 2025
@rarepolz rarepolz closed this Nov 15, 2025
@rarepolz rarepolz reopened this Nov 15, 2025
@rarepolz rarepolz changed the title refactor(sdk): replace dataclasses.replace with explicit factory methods refactor(sdk): replace dataclasses.replace with factory methods Nov 15, 2025
@rarepolz rarepolz closed this Nov 15, 2025
@rarepolz rarepolz reopened this Nov 15, 2025
@rarepolz rarepolz marked this pull request as ready for review November 15, 2025 16:59
chained_invoke_details=self.chained_invoke_details,
)

def create_merged_from_previous(self, previous_operation: Operation) -> Operation:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove references of replace in favour of creating immutable objects

2 participants