add required config file #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
approved these changes
Feb 21, 2019
Contributor
tautschnig
left a comment
tautschnig
left a comment
There was a problem hiding this comment.
I think it would be good to insert some comment into the file as empty files are really hard to make sense of. Something along the lines of "aws-c-common requires a configuration file. We do not currently need to set any options."
david-koenig
approved these changes
Feb 21, 2019
feliperodri
pushed a commit
to feliperodri/aws-encryption-sdk-c
that referenced
this pull request
Mar 6, 2020
* add required config file * add comments to the config.h file as per PR review
feliperodri
pushed a commit
to thisistegan/aws-encryption-sdk-c
that referenced
this pull request
Mar 6, 2020
* add required config file * add comments to the config.h file as per PR review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Due to a change in the upstream aws-c-common library, the CBMC proofs require an additional .h file. This PR adds the file.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.