Fix for issue #356 HKDF infinite loop bug for n = 255 #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-koenig
suggested changes
May 8, 2019
…to account for big endian architecture
david-koenig
approved these changes
May 10, 2019
Contributor
david-koenig
left a comment
david-koenig
left a comment
There was a problem hiding this comment.
Non blocking comments on naming of things only. No need for reapproval if you make those changes.
feliperodri
pushed a commit
to feliperodri/aws-encryption-sdk-c
that referenced
this pull request
Mar 6, 2020
* Fix for issue aws#356 HKDF infinite loop bug for n = 255 * Changed pointer casting to integer cast and unsigned int to uint32_t to account for big endian architecture * Naming is hard. Updated variable names from PR suggestion
feliperodri
pushed a commit
to thisistegan/aws-encryption-sdk-c
that referenced
this pull request
Mar 6, 2020
* Fix for issue aws#356 HKDF infinite loop bug for n = 255 * Changed pointer casting to integer cast and unsigned int to uint32_t to account for big endian architecture * Naming is hard. Updated variable names from PR suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#356
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.