Update Makefile.common as part of attempt to fix S3 sync issues #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feliperodri
approved these changes
Sep 8, 2020
karkhaz
reviewed
Sep 8, 2020
.cbmc-batch/jobs/Makefile.common
Outdated
| then \ | ||
| cd $(BASEDIR); \ | ||
| git clone --quiet --depth 30 https://github.com/awslabs/aws-c-common.git $(COMMON_REPO_NAME); \ | ||
| git clone --quiet --depth 100 https://github.com/awslabs/aws-c-common.git $(COMMON_REPO_NAME); \ |
Contributor
There was a problem hiding this comment.
I suggest removing --depth entirely, since this problem will just recur again in the future.
Contributor
Author
There was a problem hiding this comment.
Great, it's been removed!
karkhaz
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Increases clone depth for aws-c-common in Makefile.common to 100 to see if insufficient clone depth was the problem.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: