fix: resource exhaustion from an incomplete encrypted message #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decrypt needs to actively verify that it has reached the end of the encrypted message. This fix ensures an error on an incomplete encrypted message Also, the signature_info parsing needed to be updated, to handle an incomplete signature block. Browsers were never impacted, but the tests were included for completeness.
seebees
force-pushed
the
incomplete-ciphertext
branch
from
19caf58 to
470fb45
Compare
scottarc
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decrypt needs to actively verify
that it has reached the end of the encrypted message.
This fix ensures an error on an incomplete encrypted message
Also, the signature_info parsing needed to be updated,
to handle an incomplete signature block.
Browsers were never impacted,
but the tests were included for completeness.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: