Java: Adapt to unboxed Java primitives #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 19, 2019 11:09
This essentially boxes a byte[] in one big box rather than an array of (potentially millions of) UByte boxes.
Dafny no longer uses Byte (or UByte) in generated Java code.
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
An array of generic type is now represented as a java.lang.Object rather than a dafny.Array.
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Author
This is the good old “can't find Mono” problem. Not sure what to do about it in CI, since the solution on my machine was IIRC to clean up output directories and/or re-restore. |
Contributor
|
Going ahead with merging this to bring the |
josecorella
pushed a commit
to josecorella/aws-encryption-sdk-dafny
that referenced
this pull request
Oct 11, 2023
* feat: add comparison operations * m * move * m
josecorella
pushed a commit
that referenced
this pull request
Oct 11, 2023
* feat: add comparison operations * m * move * m
josecorella
pushed a commit
that referenced
this pull request
Oct 11, 2023
* feat: add comparison operations * m * move * m
josecorella
pushed a commit
that referenced
this pull request
Oct 11, 2023
* feat: add comparison operations * m * move * m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Dafny has a PR (dafny-lang/dafny#472) to get Java code to use unboxed primitive types for a 3x-4x speedup by our benchmark, bringing Java performance in line with C#. It's a breaking change for externs, however, so this PR makes the corresponding changes.
This probably shouldn't be merged until the Dafny PR is.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.