Rework parsers to allow pulling from source for AL2023 #1004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Put parsers into separate AL_TAG specific Dockerifles - Allow AL2 to continue to pull from fluent-bit-docker-image (prevent regression) - Allow AL2023 to pull parsers from source (fixes)
danehlim
reviewed
Sep 24, 2025
| # Create required directories | ||
| RUN mkdir -p /fluent-bit/bin /fluent-bit/etc /fluent-bit/log | ||
|
|
||
| # Accept build args for consistency (not used in AL2) |
There was a problem hiding this comment.
nit: What do we gain by accepting the build args if they are not used? I guess if someone is used to passing args for AL2023 then switches to AL2, would it fail for them if they (or their automation) pass these args?
There was a problem hiding this comment.
Nothing to be honest, if we decided to use them we would need to ARG them in and make use
danehlim
approved these changes
Sep 24, 2025
mye956
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Built local images AL2/AL2023 and validated:
make debugsucceeded: yesInteg tests succeeded: yes
New tests cover the changes: no
Description for the changelog
Enhancement: AL2023 uses parsers from fluent-bit source
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.