Improve format specifiers in logs #1097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #1097 +/- ##
===============================================
+ Coverage 96.54% 98.31% +1.77%
===============================================
Files 9 4 -5
Lines 5643 1189 -4454
Branches 641 369 -272
===============================================
- Hits 5448 1169 -4279
+ Misses 9 0 -9
+ Partials 186 20 -166
Continue to review full report at Codecov.
|
muneebahmed10
changed the title
aggarw13
reviewed
Aug 5, 2020
aggarw13
reviewed
Aug 5, 2020
sarenameas
previously approved these changes
Aug 5, 2020
aggarg
previously approved these changes
Aug 7, 2020
muneebahmed10
force-pushed
the
format-specifier
branch
from
c4a4f1c to
8f3c930
Compare
aggarg
approved these changes
Aug 7, 2020
sarenameas
approved these changes
Aug 7, 2020
leegeth
pushed a commit
to leegeth/aws-iot-device-sdk-embedded-C
that referenced
this pull request
Aug 27, 2020
* Remove C99 %hhu format specifier * Add unsigned long to %lu format specifiers * Log stringified status codes instead of integers
leegeth
pushed a commit
to leegeth/aws-iot-device-sdk-embedded-C
that referenced
this pull request
Aug 28, 2020
* Remove C99 %hhu format specifier * Add unsigned long to %lu format specifiers * Log stringified status codes instead of integers
leegeth
pushed a commit
to leegeth/aws-iot-device-sdk-embedded-C
that referenced
this pull request
Aug 31, 2020
* Remove C99 %hhu format specifier * Add unsigned long to %lu format specifiers * Log stringified status codes instead of integers
leegeth
pushed a commit
to leegeth/aws-iot-device-sdk-embedded-C
that referenced
this pull request
Sep 1, 2020
* Remove C99 %hhu format specifier * Add unsigned long to %lu format specifiers * Log stringified status codes instead of integers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Remove C99 %hhu format specifiers, add casts to unsigned long wherever %lu is used for size_t, and log strings instead of status codes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.