Skip to content

Conversation

@aggarw13
Copy link

@aggarw13 aggarw13 commented Aug 17, 2020

  • Add CBMC proof for the MQTT_GetSubAckStatusCodes API function
  • Update MQTT_GetSubAckStatusCodes API signature and its tests for issue found with the CBMC proof

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2020

Codecov Report

Merging #1132 into development will increase coverage by 2.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1132      +/-   ##
===============================================
+ Coverage        96.54%   98.85%   +2.30%     
===============================================
  Files                9        4       -5     
  Lines             5643     1309    -4334     
  Branches           641      393     -248     
===============================================
- Hits              5448     1294    -4154     
+ Misses               9        0       -9     
+ Partials           186       15     -171     
Impacted Files Coverage Δ
libraries/standard/mqtt/src/mqtt.c 99.48% <ø> (+5.06%) ⬆️
libraries/standard/mqtt/src/mqtt_lightweight.c 97.42% <ø> (+2.90%) ⬆️
libraries/standard/mqtt/src/mqtt_state.c 98.46% <ø> (+2.52%) ⬆️
libraries/standard/http/src/http_client.c 100.00% <100.00%> (+12.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 264b483...38d0c36. Read the comment docs.

@aggarw13 aggarw13 requested a review from sarenameas August 17, 2020 21:17
@markrtuttle markrtuttle self-requested a review August 17, 2020 22:36
@aggarw13 aggarw13 requested a review from sarenameas August 18, 2020 00:08
sarenameas
sarenameas previously approved these changes Aug 18, 2020
cobusve
cobusve previously approved these changes Aug 18, 2020
@aggarw13 aggarw13 dismissed stale reviews from markrtuttle, cobusve, and sarenameas via a3a1027 August 18, 2020 19:07
@aggarw13 aggarw13 merged commit 707cbe3 into aws:development Aug 18, 2020
@aggarw13 aggarw13 deleted the proof/mqtt-getsubackstatuscodes branch August 18, 2020 22:21
leegeth pushed a commit to leegeth/aws-iot-device-sdk-embedded-C that referenced this pull request Aug 27, 2020
* Add CBMC proof for MQTT_GetSubAckStatusCodes function
* Fix parameter type in API signature found by CBMC proof
leegeth pushed a commit to leegeth/aws-iot-device-sdk-embedded-C that referenced this pull request Aug 28, 2020
* Add CBMC proof for MQTT_GetSubAckStatusCodes function
* Fix parameter type in API signature found by CBMC proof
leegeth pushed a commit to leegeth/aws-iot-device-sdk-embedded-C that referenced this pull request Aug 31, 2020
* Add CBMC proof for MQTT_GetSubAckStatusCodes function
* Fix parameter type in API signature found by CBMC proof
leegeth pushed a commit to leegeth/aws-iot-device-sdk-embedded-C that referenced this pull request Sep 1, 2020
* Add CBMC proof for MQTT_GetSubAckStatusCodes function
* Fix parameter type in API signature found by CBMC proof
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants