-
Couldn't load subscription status.
- Fork 642
Add tracking branch for coreJSON #1395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Other repos are converted but haven't deleted their master branch yet. Should we update them all at once? |
sarenameas
reviewed
Nov 18, 2020
| url = https://github.com/FreeRTOS/coreHTTP.git | ||
| [submodule "libraries/standard/coreJSON"] | ||
| path = libraries/standard/coreJSON | ||
| branch = main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like it's lame we have to do this
sarenameas
reviewed
Nov 18, 2020
Co-authored-by: SarenaAWS <6563840+sarenameas@users.noreply.github.com>
nateglims
previously approved these changes
Nov 18, 2020
sarenameas
previously approved these changes
Nov 18, 2020
sarenameas
previously approved these changes
Nov 19, 2020
dan4thewin
previously approved these changes
Nov 19, 2020
sarenameas
approved these changes
Nov 19, 2020
dan4thewin
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
git submodule update --remote -ffails forcoreJSONsubmodule as the submodule pointer update is attempted onorigin/masterinstead oforigin/mainThis PR fixes the issue by adding a tracking branch configuration for the
coreJSONsubmodule.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.