Add close callback to network interface #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkwicker
requested review from
RichardBarry,
abhidixi11,
gordonwang0 and
muneebahmed10
| status = IOT_NETWORK_SUCCESS; | ||
| } | ||
|
|
||
| IOT_FUNCTION_CLEANUP_END(); |
Contributor
There was a problem hiding this comment.
Should be IOT_FUNCTION_EXIT_NO_CLEANUP() to be consistent with the way we use these macros. Same for the mbedtls file.
abhidixi11
approved these changes
Nov 12, 2019
Contributor
abhidixi11
left a comment
abhidixi11
left a comment
There was a problem hiding this comment.
Minor changes about doxygen comments and a question about close reason, otherwise looks good.
libraries/platform/iot_network.h
Outdated
| * @param[in] pConnection The connection on which data is available, defined by | ||
| * the network stack. | ||
| * @param[in] reason The reason the connection was closed | ||
| * @param[in] pContext The third argument passed to @ref platform_network_function_setreceivecallback. |
Contributor
There was a problem hiding this comment.
should be platform_network_function_setclosecallback().
gordonwang0
approved these changes
Nov 12, 2019
abhidixi11
reviewed
Nov 12, 2019
muneebahmed10
approved these changes
Nov 12, 2019
abhidixi11
reviewed
Nov 12, 2019
libraries/platform/iot_network.h
Outdated
| * A function with this signature may be set with @ref platform_network_function_setclosecallback | ||
| * to be invoked when the network connection is closed. | ||
| * | ||
| * @param[in] pConnection The connection on which data is available, defined by |
Contributor
There was a problem hiding this comment.
Should read: The connection that is being closed...
Contributor
Author
There was a problem hiding this comment.
good catch, fixed.
leegeth
pushed a commit
to leegeth/aws-iot-device-sdk-embedded-C
that referenced
this pull request
Aug 27, 2020
leegeth
pushed a commit
to leegeth/aws-iot-device-sdk-embedded-C
that referenced
this pull request
Aug 28, 2020
leegeth
pushed a commit
to leegeth/aws-iot-device-sdk-embedded-C
that referenced
this pull request
Aug 31, 2020
leegeth
pushed a commit
to leegeth/aws-iot-device-sdk-embedded-C
that referenced
this pull request
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #524
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.