Update samples and builder with improved proxy support #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinboswell
approved these changes
May 18, 2021
| if (args.proxy_host): | ||
| proxy_options = http.HttpProxyOptions(host_name=args.proxy_host, port=args.proxy_port) | ||
| proxy_options = None | ||
| if (args.proxy_host): |
Contributor
There was a problem hiding this comment.
Should we check the proxy_port is non-zero like we do in all the other languages?
Contributor
There was a problem hiding this comment.
Oh, nevermind, it's defaulted.
graebm
reviewed
May 18, 2021
Contributor
graebm
left a comment
graebm
left a comment
There was a problem hiding this comment.
search the codebase for any other uses of websocket_proxy_options you might have missed
graebm
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.