feat(eksapi): accept and configure nodeadm feature gates #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndbaker1
reviewed
Jul 7, 2025
Contributor
ndbaker1
left a comment
ndbaker1
left a comment
There was a problem hiding this comment.
sgtm, just want a small change
mselim00
commented
Jul 11, 2025
| stackName := m.getUnmanagedNodegroupStackName() | ||
| klog.Infof("creating unmanaged nodegroup stack %s...", stackName) | ||
| userData, userDataIsMimePart, err := generateUserData(opts.UserDataFormat, cluster, opts) | ||
| userData, userDataIsMimePart, err := generateUserData(cluster, opts) |
Contributor
Author
There was a problem hiding this comment.
passing opts.UserDataFormat was redundant, opts is already passed
HusainZafar
reviewed
Jul 11, 2025
| return buf.String(), userDataIsMimePart, nil | ||
| } | ||
|
|
||
| func extractFeatureGates(featureGatePairs []string) (map[string]bool, error) { |
Contributor
There was a problem hiding this comment.
Assuming the CLI framework doesn't support a map[string]string/map[string]bool, this looks fine
cartermckinnon
approved these changes
Jul 12, 2025
HusainZafar
approved these changes
Jul 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Enables a pass-through flag for nodeadm feature gates
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.