fix: arg list too long when uploading metrics to cloudwatch #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0marperez
changed the title
ianbotsf
approved these changes
Nov 10, 2025
| if [ "$RELEASE_METRICS" == "true" ]; then | ||
| # For record-keeping | ||
| uploadToMetricsBucket "$metrics_file" "$GITHUB_REPOSITORY"-v"$IDENTIFIER".csv | ||
| uploadToMetricsBucket "$metrics_file" "$GITHUB_REPOSITORY"-"$IDENTIFIER".csv |
Contributor
There was a problem hiding this comment.
Question: Why is the v removed? Was it necessary before but now isn't?
Contributor
Author
There was a problem hiding this comment.
It's being removed because it was actually never necessary. The IDENTIFIER already includes a v.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes "Argument list too long" errors when uploading artifact size metrics to CloudWatch. See:
https://github.com/aws/aws-sdk-kotlin/actions/runs/19149586252/job/54736048809
Description of changes:
vfrom version identifier used in S3.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.