Skip to content

feat: Kotlin/Native Windows compilation #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025
Merged

feat: Kotlin/Native Windows compilation #91

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8853d53
⚠️ WIP changes for Windows compilation
ianbotsf Jun 4, 2025
8938da4
clean up
ianbotsf Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 6 additions & 75 deletions build-plugins/kmp-conventions/src/main/kotlin/aws/sdk/kotlin/gradle/kmp/ConfigureTargets.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,11 @@ package aws.sdk.kotlin.gradle.kmp

import aws.sdk.kotlin.gradle.util.prop
import org.gradle.api.Project
import org.gradle.api.publish.maven.tasks.AbstractPublishToMaven
import org.gradle.api.publish.tasks.GenerateModuleMetadata
import org.gradle.api.tasks.testing.Test
import org.gradle.api.tasks.testing.logging.TestExceptionFormat
import org.gradle.kotlin.dsl.*
import org.gradle.kotlin.dsl.named
import org.jetbrains.kotlin.gradle.ExperimentalKotlinGradlePluginApi
import org.jetbrains.kotlin.gradle.dsl.KotlinMultiplatformExtension
import org.jetbrains.kotlin.gradle.plugin.mpp.KotlinNativeTarget
import org.jetbrains.kotlin.konan.target.Family
import org.jetbrains.kotlin.konan.target.HostManager
import java.io.File

Expand Down Expand Up @@ -51,7 +47,7 @@ val Project.hasWindows: Boolean get() = hasNative || files.any { it.name == "win
* Test if a project follows the convention and needs configured for KMP (used in handful of spots where we have a
* subproject that is just a container for other projects but isn't a KMP project itself).
*/
public val Project.needsKmpConfigured: Boolean get() = hasCommon || hasJvm || hasNative || hasJs || hasJvmAndNative || hasDesktop || hasLinux || hasApple || hasWindows
val Project.needsKmpConfigured: Boolean get() = hasCommon || hasJvm || hasNative || hasJs || hasJvmAndNative || hasDesktop || hasLinux || hasApple || hasWindows

@OptIn(ExperimentalKotlinGradlePluginApi::class)
fun Project.configureKmpTargets() {
Expand Down Expand Up @@ -112,22 +108,15 @@ fun Project.configureKmpTargets() {
// FIXME Configure JS

if (NATIVE_ENABLED) {
if (hasApple) {
if ((hasApple || hasDesktop) && HostManager.hostIsMac) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the hasDesktop addition necessary here? IIRC we don't use the "desktop" source set anywhere. Was this just for correctness?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I was condensing the boolean logic from L124-130. If we have no plans to use desktop in the future I can remove this and related declarations.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can leave it in place for now and look at simplifying after development is complete

kmpExt.apply { configureApple() }
}
if (hasWindows) {
if ((hasWindows || hasDesktop) && HostManager.hostIsMingw) {
kmpExt.apply { configureWindows() }
}
if (hasLinux) {
if ((hasLinux || hasDesktop) && HostManager.hostIsLinux) {
kmpExt.apply { configureLinux() }
}
if (hasDesktop) {
kmpExt.apply {
configureLinux()
configureMacos()
configureWindows()
}
}
}

kmpExt.configureSourceSetsConvention()
Expand Down Expand Up @@ -193,8 +182,7 @@ fun Project.configureMacos() {

fun Project.configureWindows() {
kotlin {
// FIXME Set up Docker files and CMake tasks for Windows
// mingwX64()
mingwX64()
}
}

Expand All @@ -213,60 +201,3 @@ fun KotlinMultiplatformExtension.configureSourceSetsConvention() {

val Project.JVM_ENABLED get() = prop("aws.kotlin.jvm")?.let { it == "true" } ?: true
val Project.NATIVE_ENABLED get() = prop("aws.kotlin.native")?.let { it == "true" } ?: true

/**
* Kotlin/Native Linux and Windows targets are generally enabled on all hosts since
* the Kotlin toolchain and backend compilers support cross compilation. We
* are using cinterop and have to compile CRT for those platforms which sometimes
* requires using docker which isn't always available in CI or setup in users environment.
*
* See [KT-30498](https://youtrack.jetbrains.com/issue/KT-30498)
*/
fun Project.disableCrossCompileTargets() {
plugins.withId("org.jetbrains.kotlin.multiplatform") {
configure<KotlinMultiplatformExtension> {
targets.withType<KotlinNativeTarget> {
val knTarget = this
when {
HostManager.hostIsMac && (knTarget.isLinux || knTarget.isWindows) -> disable(knTarget)
HostManager.hostIsLinux && knTarget.isApple -> disable(knTarget)
HostManager.hostIsMingw && (knTarget.isLinux || knTarget.isApple) -> disable(knTarget)
}
}
}
}
}

private val KotlinNativeTarget.isLinux: Boolean
get() = konanTarget.family == Family.LINUX

private val KotlinNativeTarget.isApple: Boolean
get() = konanTarget.family.isAppleFamily

private val KotlinNativeTarget.isWindows: Boolean
get() = konanTarget.family == Family.MINGW

internal fun Project.disable(knTarget: KotlinNativeTarget) {
logger.warn("disabling Kotlin/Native target: ${knTarget.name}")
knTarget.apply {
compilations.all {
cinterops.all {
tasks.named(interopProcessingTaskName).configure { enabled = false }
}
compileTaskProvider.configure { enabled = false }
}

binaries.all {
linkTaskProvider.configure { enabled = false }
}

mavenPublication {
tasks.withType<AbstractPublishToMaven>().configureEach {
onlyIf { publication != this@mavenPublication }
}
tasks.withType<GenerateModuleMetadata>().configureEach {
onlyIf { publication != this@mavenPublication }
}
}
}
}