-
Notifications
You must be signed in to change notification settings - Fork 570
Add events for lambda ALB integration #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
=======================================
Coverage 68.89% 68.89%
=======================================
Files 17 17
Lines 659 659
=======================================
Hits 454 454
Misses 165 165
Partials 40 40Continue to review full report at Codecov.
|
|
Can you add test and md doc ? (you can copy example https://github.com/aws/aws-lambda-go/blob/master/events/apigw_test.go#L13) |
qneyrat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add tests
|
Thank you for taking the time to reply, I'll add tests tomorrow. |
Changed the type time. s/Lambda/ALB/ updated field name casing for ALBTargetGroupRequestContext.ELB
s/Lambda/ALB/
fixup example
…etGroupEvents.md doc updates
|
Thanks for adding the tests. I've made some cosmetic changes to the naming and updated the docs. |
Minor edit to an overview section.
furiousbunny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
The recently added feature of ALBs was to integrate with Lambdas using a target group, and this PR is adding the events needed to this package.
I was working on integrating a Lambda with an ALB and needed to create these events to be able to write my lambda.
I've written them based on documentation page for using Lambda as ALB target.
https://docs.aws.amazon.com/elasticloadbalancing/latest/application/lambda-functions.html#respond-to-load-balancer
Edit:
This fixes parts of #146