Skip to content

Conversation

@sjurtf
Copy link
Contributor

@sjurtf sjurtf commented Dec 6, 2018

The recently added feature of ALBs was to integrate with Lambdas using a target group, and this PR is adding the events needed to this package.

I was working on integrating a Lambda with an ALB and needed to create these events to be able to write my lambda.

I've written them based on documentation page for using Lambda as ALB target.
https://docs.aws.amazon.com/elasticloadbalancing/latest/application/lambda-functions.html#respond-to-load-balancer

Edit:
This fixes parts of #146

@codecov-io
Copy link

codecov-io commented Dec 6, 2018

Codecov Report

Merging #149 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   68.89%   68.89%           
=======================================
  Files          17       17           
  Lines         659      659           
=======================================
  Hits          454      454           
  Misses        165      165           
  Partials       40       40

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 554303c...c5d3d93. Read the comment docs.

@qneyrat
Copy link

qneyrat commented Dec 13, 2018

Can you add test and md doc ? (you can copy example https://github.com/aws/aws-lambda-go/blob/master/events/apigw_test.go#L13)

Copy link

@qneyrat qneyrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests

@sjurtf
Copy link
Contributor Author

sjurtf commented Dec 13, 2018

Thank you for taking the time to reply, I'll add tests tomorrow.

Changed the type time. s/Lambda/ALB/
updated field name casing for ALBTargetGroupRequestContext.ELB
s/Lambda/ALB/
@bmoffatt
Copy link
Collaborator

Thanks for adding the tests. I've made some cosmetic changes to the naming and updated the docs.

Copy link

@furiousbunny furiousbunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@furiousbunny furiousbunny merged commit 1be8070 into aws:master Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants