Add null checks to handle null new image and old image in StreamRecord #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @yongruigao, Thanks for the PR! I'll have a look at it and see if we can put it into the next release. Mark |
Contributor
|
Looks good to me. @carlzogh your thoughts? |
carlzogh
suggested changes
Jun 21, 2021
...services/lambda/runtime/events/transformers/v1/dynamodb/DynamodbStreamRecordTransformer.java
Show resolved
Hide resolved
carlzogh
approved these changes
Jun 21, 2021
Contributor
carlzogh
left a comment
carlzogh
left a comment
There was a problem hiding this comment.
LGTM - thanks for the contribution!
andclt
approved these changes
Aug 10, 2022
Contributor
|
@yongruigao, can you rebase this branch from aws:events-v4-serialization-v2 Thanks. |
…tributeValueMapV1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None
Description of changes:
Old image and new image don't always exist in the DynamoDB stream record. When either of them don't exist, a NullPointerException would be thrown without null checks. The same null checks exist in com.amazonaws.services.lambda.runtime.events.transformers.v2.dynamodb.DynamodbStreamRecordTransformer, but not com.amazonaws.services.lambda.runtime.events.transformers.v1.dynamodb.DynamodbStreamRecordTransformer
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.