Skip to content

Conversation

@stefanbotez
Copy link
Contributor

Description of changes:

  • Fixed issue when if statement was checking for ExtendedError, but it should have checked for Error. That if statement was never passed, so the logs of the error were not complete.
  • Added a test for the above fix. Before there was a test that checked the logging error behavior, but it checked with a CircularError, which was only testing the case when the try statement failed. Added a test that would test the behavior for when the try statement succeeds (i.e. testing the _withEnumerableProperties method).
  • When facing a SyntaxError only the message of the error would get logged. Changed it so that the whole error would get logged.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@edhzsz edhzsz merged commit e5d6234 into aws:main Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants