Upgrade to hyper/http 1.0

[jonhoo]

Now that version 1.0 of the hyper and http* crates are out, the lambda* crates should probably follow suit. Unfortunately, it's a decently heavy lift, especially due to Body changing from a concrete type to a trait (hyperium/hyper#2345). I took a stab at it, but quickly got lost in a sea of <B: Body>s, and figured I'd leave it to those who know the library best.

A few bits I did pick up that may come in handy for someone wanting to take this on:

• body::to_bytes(body).await? becomes body.collect().await?.to_bytes() via http_body_util::BodyExt
• The old Body becomes BoxBody<hyper::body::Bytes, hyper::Error> via http_body_util::combinators::BoxBody if you want to keep it fully type-erased like it is today. Otherwise, hyper::body::Incoming is the right replacement type for at least most Responses.
• There is no more pooling http client, nor a Connector trait (or rather, they're relegated to hyper_util::client::legacy). Instead, there is now hyper::client::conn::http1::Connection.

Also worth linking this, which it took me a bit to find: https://hyper.rs/guides/1/upgrading/

[calavera]

What are the benefits of migrating to the new version?

I tried to do it too, and I found the lack of documentation about all the deprecated things troubling. So I'm reticent to spend quite a lot time without knowing that's worth the work.

If anyone wants to do the heavy lifting, we appreciate the contributions.

[davidbarsky]

What are the benefits of migrating to the new version?

Saying this for any readers—http is a public dependency of the Lambda runtime, which will manifest in (indirectly related) errors like #738.

[simbleau]

What are the benefits of migrating to the new version?

I tried to do it too, and I found the lack of documentation about all the deprecated things troubling. So I'm reticent to spend quite a lot time without knowing that's worth the work.

If anyone wants to do the heavy lifting, we appreciate the contributions.

A benefit would be to play nicely with other libraries, e.g. Axum, who have followed suit and updated http to 1.0. Hence, anyone making a Lambda service using Axum might run into this:

[simbleau]

I gave the PR a start - updating to the correct versions. Unfortunately I hit a snag due to poor documentation. Hopefully if someone understands the hyper Client or HttpConnector's behavior prior to 1.0 and feels comfortable adding to the PR, please go ahead! :)

[calavera]

I've made some progress on this. I'll probably have a PR ready this week.

[simbleau]

I've made some progress on this. I'll probably have a PR ready this week.

Awesome! Hope you're able to re-use some of the revisions I authored or add onto my PR! Sorry it's been taking me a while, limited bandwidth.

[calavera]

This PR should fix it, but I'll really appreciate you testing your functions with it before I merge it:

#749

You can install the dependency from GitHub directly using this in your Cargo.toml file:

lambda_http = { git = "https://github.com/awslabs/aws-lambda-rust-runtime", branch = "hyper1_upgrade" }

[jonhoo]

It's a small data point, but I upgraded wewerewondering.com to this (https://github.com/jonhoo/wewerewondering/tree/hyper-1), and that seems to be working fine!

[calavera]

Thanks for the update @jonhoo ! Hopefully we can get a release next week.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for the maintainers of this repository to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.