Skip to content

Conversation

@AnderEnder
Copy link
Contributor

This is a workaround for Github Actions to support rust unstable environment - nightly.

Changes

  • nightly as a new stage
  • nightly is enabled only for ubuntu
  • add additional variable allow_failure
  • allow_failure continues failed steps on nightly
  • move environment variable RUST_BACKTRACE to global scope.

Result: in case of failure, nightly stage is marked as succeeded.

Example of simulation when one test is broken:
https://github.com/AnderEnder/aws-lambda-rust-runtime/runs/306148543

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@AnderEnder AnderEnder changed the title test failure workaround nightly failure workaround Nov 16, 2019
Copy link
Contributor

@davidbarsky davidbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we address the deprecation notice that came up as a warning? https://github.com/actions-rs/components-nightly#deprecation-notice

@AnderEnder
Copy link
Contributor Author

@davidbarsky, done.

@AnderEnder AnderEnder changed the title nightly failure workaround CI: nightly failure workaround Nov 17, 2019
@davidbarsky davidbarsky merged commit 6866f2b into aws:master Nov 17, 2019
@davidbarsky
Copy link
Contributor

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants