Making Error type public so that consumers don't have to create their own type alias #298
Conversation
|
You beat me to the punch by minutes! |
|
@bahildebrand My bad I should have marked this one as assigned! |
bahildebrand
left a comment
bahildebrand
left a comment
There was a problem hiding this comment.
LGTM other than the small change.
lambda-runtime/examples/basic.rs
Outdated
|
|
||
| #[tokio::main] | ||
| async fn main() -> Result<(), Error> { | ||
| async fn main() -> Result<(), lambda_runtime::Error> { |
There was a problem hiding this comment.
Can we include the error type instead? Same for the other examples as well.
There was a problem hiding this comment.
Ah yeah I totally agree, I think it would look better as an include. Let me address that and push the change up.
All good haha! It wasn't a large change, so not much time was spent on it. |
bahildebrand
left a comment
bahildebrand
left a comment
There was a problem hiding this comment.
Sorry I meant to approve on the last one. My comment is a nit. Up to you if you want to address it.
rimutaka
left a comment
rimutaka
left a comment
There was a problem hiding this comment.
Looks good and timely for v.0.3
… in imports instead.
I agree with your comment! Just pushed a commit up with that change. |
3 participants
Issue #, if available: #297
Description of changes: The
Errortype alias was formerly public only to the lambda_runtime crate. Made this public and replace customer type aliases elsewhere.By submitting this pull request