Skip to content

Implement tower::Service trait #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 21, 2022
Merged

Implement tower::Service trait #401

merged 12 commits into from
Jan 21, 2022

Conversation

@nmoutschen
Copy link
Contributor

@nmoutschen nmoutschen commented Jan 14, 2022 •
edited by calavera
Loading

Issue #, if available: #374

Description of changes:

Replaces all custom traits with tower::Service<LambdaEvent>:

  • Switch lambda_runtime::Runtime
  • Switch lambda_extension::Extension
  • Switch lambda_http::Handler
  • Add run helper tower::Service<Request>
  • Add integration test for tower::Service<Request>
  • Update lambda_integration_tests
  • Update documentation

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

Closes #374
Closes #96

@nmoutschen nmoutschen mentioned this pull request Jan 17, 2022
Closed
calavera
calavera approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like how this turned out, good job!

coltonweaver
coltonweaver approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@coltonweaver coltonweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @calavera. This is a very clean change and easy to follow. Great work.

@nmoutschen
Copy link
Contributor Author

nmoutschen commented Jan 21, 2022

Thanks for the check, folks! I'll go ahead and merge this.

@nmoutschen nmoutschen merged commit f33fa05 into master Jan 21, 2022
@nmoutschen nmoutschen deleted the tower-service branch January 21, 2022 08:02
@nmoutschen nmoutschen mentioned this pull request Jan 27, 2022
Merged
2 tasks
@nmoutschen nmoutschen added the 0.5 label Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bahildebrand bahildebrand Awaiting requested review from bahildebrand

2 more reviewers

@calavera calavera calavera approved these changes

@coltonweaver coltonweaver coltonweaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

0.5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace lambda_runtime::Handler with tower::Service? Consider Alternate Handler Types

3 participants

@nmoutschen @calavera @coltonweaver