Add tracing span with request id to the handler #577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llgerard
commented
Dec 15, 2022
Tracing filters by default trim events and *spans* according to the level. This means that entering a span with a level below the threshold will be a no-op and the current span is not updated. The lambda request span is a meaningful info one, so bump to INFO level.
Contributor
|
@llgerard can you run |
Contributor
Author
|
@calavera I had it formatted already. I reran Which part looks improperly formatted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When logging errors, it is very useful to log the request Id (and xray id if available). But, not every one might want it, so we probably don't want to include it by default in every log.
The solution proposed in this PR is to use a
spanwith fields containing the request id and xray id. Then, to get the request id part of the log messages, one has to enable logging spans in the logger setup (using tracing_subscriber for example).By submitting this pull request