Skip to content

Make Kafka header values i8 instead of u8 #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2023
Merged

Make Kafka header values i8 instead of u8 #689

merged 1 commit into from
Aug 30, 2023

Conversation

@FalkWoldmann
Copy link
Contributor

@FalkWoldmann FalkWoldmann commented Aug 30, 2023

Issue #, if available:
#688
Description of changes:
Change Kafka header value to i8 from u8.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

calavera
calavera approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@calavera calavera merged commit 1781f89 into aws:main Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@calavera calavera calavera approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FalkWoldmann @calavera