Fix: Missing userNotFound field in "create/verify auth challenge" Cognito user pool events #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds `user_not_found` field to:
- `CognitoEventUserPoolsCreateAuthChallengeRequest`
- `CognitoEventUserPoolsVerifyAuthChallengeRequest`
- Adds test cases where `user_not_found` becomes `true` for:
- `CognitoEventUserPoolsDefineAuthChallengeRequest`
- `CognitoEventUserPoolsCreateAuthChallengeRequest`
- `CognitoEventUserPoolsVerifyAuthChallengeRequest`
issue aws#718
calavera
suggested changes
Nov 4, 2023
Contributor
calavera
left a comment
calavera
left a comment
There was a problem hiding this comment.
Can you run cargo fmt to fix the formatting issues? 🙏
calavera
approved these changes
Nov 4, 2023
Contributor
calavera
left a comment
calavera
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
userNotFoundfield in "create/verify auth challenge" Cognito user pool events #718Description of changes:
user_not_foundfield to:CognitoEventUserPoolsCreateAuthChallengeRequestCognitoEventUserPoolsVerifyAuthChallengeRequestuser_not_foundbecomestruefor:CognitoEventUserPoolsDefineAuthChallengeRequestCognitoEventUserPoolsCreateAuthChallengeRequestCognitoEventUserPoolsVerifyAuthChallengeRequestBy submitting this pull request