Added LogBuffering validation. #729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ul error in case the LogBuffering is not configured according to https://docs.aws.amazon.com/lambda/latest/dg/telemetry-api.html\#telemetry-api-buffering
calavera
suggested changes
Nov 14, 2023
Contributor
calavera
left a comment
calavera
left a comment
There was a problem hiding this comment.
Thanks a lot for the improvements. I left you a couple of small suggestions if you want to make the code a little bit cleaner.
lambda-extension/src/extension.rs
Outdated
Comment on lines
229
to
232
| let log_buffering_validation_result = validate_buffering_configuration(self.log_buffering); | ||
| if log_buffering_validation_result.is_err() { | ||
| return log_buffering_validation_result; | ||
| } |
Contributor
There was a problem hiding this comment.
I believe you can just do this, no need to use the result explicitly.
Suggested change
| let log_buffering_validation_result = validate_buffering_configuration(self.log_buffering); | |
| if log_buffering_validation_result.is_err() { | |
| return log_buffering_validation_result; | |
| } | |
| validate_buffering_configuration(self.log_buffering)?; |
lambda-extension/src/extension.rs
Outdated
Comment on lines
271
to
274
| let telemetry_buffering_validation_result = validate_buffering_configuration(self.telemetry_buffering); | ||
| if telemetry_buffering_validation_result.is_err() { | ||
| return telemetry_buffering_validation_result; | ||
| } |
Contributor
There was a problem hiding this comment.
I believe you can just do this, no need to use the result explicitly.
Suggested change
| let telemetry_buffering_validation_result = validate_buffering_configuration(self.telemetry_buffering); | |
| if telemetry_buffering_validation_result.is_err() { | |
| return telemetry_buffering_validation_result; | |
| } | |
| validate_buffering_configuration(self.log_buffering)?; |
calavera
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation will provide a meaningful error in case the
LogBufferingis not configured according to telemetry-api-buffering docs.Issue #, if available:
Description of changes:
Updated the
LogBufferingstruct in. Added validation and unit tests. Also update therunmethod of the extension to utilize the validation and return an error if applicable.By submitting this pull request