add lambda event agent for amazon bedrock #746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calavera
suggested changes
Dec 4, 2023
Contributor
calavera
left a comment
calavera
left a comment
There was a problem hiding this comment.
Thanks! Can you add a new line to this task so we can test this event in isolation?
https://github.com/awslabs/aws-lambda-rust-runtime/blob/main/Makefile#L66
Contributor
Author
|
Thanks for your advice! I added new line for bedrock events |
calavera
approved these changes
Dec 4, 2023
Contributor
calavera
left a comment
calavera
left a comment
There was a problem hiding this comment.
Looks great, thanks!
I'll create a new release today or tomorrow with these changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#745
Description of changes:
As of today, none of the events registered in lambda-events were related to Bedrock.
I believe that being able to execute Lambda functions in Rust is important from a performance standpoint, and being able to receive and execute events related to Bedrock would be good for the user experience of Lambda Function.
Therefore, I have added a new Event sent from Agents for Amazon Bedrock based on the schema linked here.
I may not have done everything I need to do because I started writing Rust a while ago and have no experience with OSS contributors.
If this is the case, I would appreciate it if you would let me know!
By submitting this pull request