Skip to content

Preparing for 0.2 release #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 25, 2019
Merged

Preparing for 0.2 release #75

merged 3 commits into from
Jan 25, 2019

Conversation

@sapessi
Copy link
Contributor

@sapessi sapessi commented Jan 24, 2019 •
edited
Loading

Fixed error crates missing from workspace descriptor and updated docs in errors crate.

Issue #, if available:

Description of changes:

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@sapessi sapessi requested a review from davidbarsky January 24, 2019 22:13
davidbarsky
davidbarsky suggested changes Jan 24, 2019
View reviewed changes
davidbarsky
davidbarsky approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@davidbarsky davidbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

softprops
softprops reviewed Jan 24, 2019
View reviewed changes
@softprops
Copy link
Contributor

softprops commented Jan 24, 2019

LGTM

@davidbarsky
Copy link
Contributor

davidbarsky commented Jan 25, 2019

Restarted the build in hopes of unblocking it.

@sapessi
Copy link
Contributor Author

sapessi commented Jan 25, 2019

Thanks

@sapessi sapessi merged commit 66c0ba0 into master Jan 25, 2019
@nmoutschen nmoutschen deleted the errors branch February 1, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@softprops softprops softprops left review comments

@davidbarsky davidbarsky davidbarsky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sapessi @softprops @davidbarsky