Skip to content

Conversation

@lmammino
Copy link
Contributor

@lmammino lmammino commented Feb 5, 2024

Issue #, if available:

Description of changes: If I understand the code correctly, the tracing line reports the content of the request, NOT the response.

If that's correct, I believe we should apply this change to make debugging a little bit easier.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@greenwoodcm
Copy link
Contributor

the terminology is a little ambiguous. this is the event payload that the Lambda function was invoked with (so in that regard it's a request). but function code (or runtime code here) polls the Lambda runtime APIs for work and receives one payload at a time, as responses to that poll. so it's a request to the Lambda function, but a response from the runtime API. maybe we should change this line to say neither request nor response, but something like "event" or "payload".

Co-authored-by: David Calavera <david.calavera@gmail.com>
@greenwoodcm
Copy link
Contributor

looks like you need to reformat

@calavera
Copy link
Contributor

I'll format it.

@calavera calavera merged commit 73736fd into aws:main Feb 14, 2024
@lmammino
Copy link
Contributor Author

Sorry, read a bit too late. Thanks for taking care of it, @calavera

@lmammino lmammino deleted the patch-1 branch February 14, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants