Use New Docker Images in GitHub Workflows #2752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
force-pushed
the
gh-docker-image-build-p3
branch
from
376de25 to
f279a07
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2752 +/- ##
==========================================
- Coverage 78.91% 78.91% -0.01%
==========================================
Files 677 677
Lines 115525 115525
Branches 16248 16249 +1
==========================================
- Hits 91171 91165 -6
- Misses 23558 23564 +6
Partials 796 796 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
approved these changes
Oct 16, 2025
torben-hansen
approved these changes
Oct 16, 2025
justsmth
pushed a commit
that referenced
this pull request
Oct 27, 2025
### Issues: Resolves P322305594 ### Description of changes: We switched over to new Docker images recently with #2752. The new `ubuntu:22.04` image has the `autoconf-archive` package that will activate some strict autoconf macros, resulting in `-Werror` being added. Therefore, our CI has been failing, partly due to functions that we deprecated and partly due to librelp code itself. Most of librelp's CI overrides these macros using `--enable-compile-warnings=yes`, so this PR is adding the same thing to best mimic the testing environment for librelp. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Migrate workflows to use new docker images from #2746.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.